Babe epoch newtype #1596
Merged
Babe epoch newtype #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
approved these changes
Sep 17, 2023
bkchr
approved these changes
Sep 17, 2023
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Removal of verbatim duplication of BABE's `Epoch` struct in the client. I think is better to have one single definition and wrap the primitive `Epoch` in a newtype (required because we need to implement the `Epoch` trait).
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 26, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 27, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* remove without_storage_info from pallet-bridge-parachains * fix benchmarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of verbatim duplication of BABE's
Epochstruct in the client.I think is better to have one single definition and wrap the primitive
Epochin a newtype (required because we need to implement theEpochtrait).